serafim
/
dos
1
0
Fork 2
Code Issues Pull Requests Packages Projects Releases Wiki Activity

delete check_sum function and moved its logic inside tcp_syn #13

Merged
dr-wh0 merged 4 commits from my_tcp_syn into dev 2025-04-08 01:48:15 +03:00
Conversation 0 Commits 4 Files Changed 3 +53 -51
Urmipie commented 2025-04-07 19:57:59 +03:00
Collaborator
Copy Link
No description provided.
Urmipie added 7 commits 2025-04-07 19:58:00 +03:00
10276f9775 feat: add my_tcp_syn and checksum. modified main to codestyle 
my_tcp_syn make tcp syn requests without waiting for confirmation.
6488a42fb6 fix: code style 
moved initialisation to top of function, expanded comments
733b5b6486 fix: source IP, code style, readme 
-instead of real IP packet send fake one (localhost currently)
-more stylish code style
-objectivly cooler readme
775fb4cbd8 chore: delete check_sum function 
check_sum function logic moved into tcp_syn
80b3fadbf3 chore: improved readme, build.sh 
build.sh now doesnt run file if compilation failed
readme now have more information about contrirbuting and running
Urmipie force-pushed my_tcp_syn from 1896e45747 to c3355c7ca8 2025-04-07 21:08:20 +03:00 Compare
Urmipie scheduled this pull request to auto merge when all checks succeed 2025-04-07 21:11:56 +03:00
Urmipie requested review from serafim 2025-04-07 21:12:45 +03:00
Urmipie requested review from dr-wh0 2025-04-07 21:12:45 +03:00
Urmipie canceled auto merging this pull request when all checks succeed 2025-04-08 01:33:48 +03:00
dr-wh0 approved these changes 2025-04-08 01:36:50 +03:00
Dismissed
src/DosAtk.cpp
@ -494,2 +462,4 @@
uint8_t *checksum_byte_ptr;
int checksum_len;
// === Инициализация переменных ===
dr-wh0 commented 2025-04-08 01:34:55 +03:00
Collaborator
Copy Link

Число объявленных и инициализированных переменных должно совпадать

Число объявленных и инициализированных переменных должно совпадать
Urmipie marked this conversation as resolved
src/DosAtk.cpp
@ -550,0 +523,4 @@
// Встроенный расчет контрольной суммы
checksum_ptr = (uint16_t *)temp_buf;
checksum_sum = 0;
checksum_len = sizeof(temp_buf);
dr-wh0 commented 2025-04-08 01:35:45 +03:00
Collaborator
Copy Link

checksum_ptr, checksum_sum, checksum_len необходимо инициализировать сначала

checksum_ptr, checksum_sum, checksum_len необходимо инициализировать сначала
Urmipie commented 2025-04-08 01:39:10 +03:00
Author
Collaborator
Copy Link

Они инициализированы на строке 459

Они инициализированы на строке 459
Urmipie marked this conversation as resolved
Urmipie added 1 commit 2025-04-08 01:44:48 +03:00
Urmipie dismissed dr-wh0’s review 2025-04-08 01:44:48 +03:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dr-wh0 approved these changes 2025-04-08 01:48:06 +03:00
dr-wh0 merged commit d2daab9650 into dev 2025-04-08 01:48:15 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
serafim
dr-wh0
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: serafim/dos#13
No description provided.
Delete Branch "my_tcp_syn"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?